Don't use @import in the legacy importer
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unfortunately may make error reports look a little odd for errors on the first line of SCSS files loaded via the legacy importer and it'll give indented-syntax errors an off-by-one error, but there's an easy fix: stop using the legacy API. Closes #340
nex3
force-pushed
the
no-legacy-import
branch
from
fe7cb48
to
0ec616e
Compare
nex3
changed the title
@import in the legacy importer
jathak
approved these changes
Oct 22, 2024
Co-authored-by: Jennifer Thakar <[email protected]>
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Oct 24, 2024
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Oct 24, 2024
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unfortunately may make error reports look a little odd for errors
on the first line of SCSS files loaded via the legacy importer and
it'll give indented-syntax errors an off-by-one error, but there's an
easy fix: stop using the legacy API.
Closes #340