Implement sass --embedded in pure JS mode
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
embedded-compiler
branch
from
9683817
to
2b23fac
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
a57567f
to
ec05f2d
Compare
4 tasks
ntkme
force-pushed
the
embedded-compiler
branch
from
ec05f2d
to
75f77ee
Compare
ntkme
force-pushed
the
embedded-compiler
branch
4 times, most recently
from
5d51360
to
b2dfcb2
Compare
ntkme
commented
Oct 28, 2024
Comment on lines
+16
to
+19
| // Node blocks launching .bat and .cmd without a shell due to CVE-2024-27980 | ||
| shell: ['.bat', '.cmd'].includes( | ||
| path.extname(compilerCommand[0]).toLowerCase() | ||
| ), |
There was a problem hiding this comment.
This is to fix local test failure: https://github.com/sass/dart-sass/actions/runs/11563285433/job/32186274921
Basically the same thing as #286
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
54de9e5
to
34c153c
Compare
ntkme
force-pushed
the
embedded-compiler
branch
from
34c153c
to
88db565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass/dart-sass#2413