Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with list items using call() on function with variable args after static args #1622

Closed
davidkpiano opened this issue Oct 25, 2015 · 1 comment · Fixed by #1630
Closed

Comments

@davidkpiano
Copy link

Sorry for the verbose bug title. This might be related to this: #1604 but it is not the same issue.

TEST:

@function foo($list) {
    @return call(bar, $list);
}

@function bar($list, $args...) {
    @return length($list);
}

test {
  test: foo(1 2 3);
}

EXPECTED: (LibSass 3.2.5 and Ruby Sass 3.4.14)

test {
  test: 3;
}

ACTUAL: (with Node-Sass 3.3.0)

test {
  test: 1;
}

Side note: I'm going to start writing basic unit tests for these in my Sassdash repo since they are all directly related to Sassdash functions, and discovered by their unit tests (~800).

@xzyfer xzyfer added this to the 3.3.1 milestone Oct 25, 2015
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 25, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Oct 25, 2015

Thanks for the report @davidkpiano I can confirm this is a regression 3.3. We'll be releasing 3.3.1 in the next couple days as regressions are being reported.

Spec added sass/sass-spec#557

@xzyfer xzyfer changed the title List items dropped when using call() on function with variable args after static args Regression with list items using call() on function with variable args after static args Oct 26, 2015
@xzyfer xzyfer self-assigned this Oct 26, 2015
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 26, 2015
This PR fixes a regression with lists as arguments to call when
the calling function has a rest parameter.

Fixes sass#1622
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Oct 26, 2015
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 26, 2015
This PR fixes a regression with lists as arguments to call when
the calling function has a rest parameter.

Fixes sass#1622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants