Fix import file resolution to match Ruby Sass #1963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch address two inconsistencies with how `@import` is resolved compared to Ruby Sass. - `.css` should not be `@import`able - `.sass` should take precedence over `.scss` files Fixes sass#1656
xzyfer
force-pushed
the
fix/import-file-resolution
branch
from
20d5058
to
e2422db
Compare
|
IMO this should wait for 3.4.0 (breaking change) and we should add an opt in config to preserve the current behavior if wanted. We added it because it was widely requested and ruby sass also allows to alter file extensions for including partials. #1893 is also related. |
|
We have decided keeping the current behaviour, and not breaking the code for people who now depending on this, is the lesser evil. This will be addressed in 4.0. |
This was referenced Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch address two inconsistencies with how
@importisresolved compared to Ruby Sass.
.cssshould not be@importable.sassshould take precedence over.scssfilesFixes #1656