Remove obsolete check for rest args after optionals #981
Conversation
Remove obsolete check for rest args after optionals
| @@ -1667,9 +1667,6 @@ namespace Sass { | |||
| if (has_rest_parameter_) { | |||
| error("functions and mixins cannot have more than one variable-length parameter", p->pstate()); | |||
| } | |||
| if (has_optional_parameters_) { | |||
There was a problem hiding this comment.
Is this correct? I believe this is still a valid error.\
The error case mentioned in the issue is
[when] optional parameter followed by a variable-length parameter
This change appears to affect the case
[when] a variable-length parameter is followed an optional parameter
Which is a legal scenario.
If this fixes the reported issues I believe the bug is due to something before this check.
There was a problem hiding this comment.
IMO it should be spot on now. The test I removed is obviously wrong, since rest parameters can come after a parameter with optional (default) value (as you can see has_optional_parameters_ is set when we had a preceding default_value. Or can you come up with a sample that doesn't behave correctly?
Fixes #980