Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Standardize on cross-spawn #1015

Closed
xzyfer opened this issue Jun 29, 2015 · 2 comments
Closed

Standardize on cross-spawn #1015

xzyfer opened this issue Jun 29, 2015 · 2 comments
Labels
Community - Help Wanted Feature - Request npm build OS - Windows
Milestone
v3.3.3

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Jun 29, 2015

There a known issues with spawn on Windows - nodejs/node-v0.x-archive#2318 as an example.

As a work around we sometimes use cross-spawn. We will move all usage of spawn to cross-spawn.
@xzyfer xzyfer added this to the next.patch milestone Jun 29, 2015
@saper
Copy link
Member

saper commented Aug 22, 2015

nodejs/node-v0.x-archive#2318 seems to me like a correct behaviour by design.

Would child_process.exec work for our tests and running git? That should solve all problems related to directly launching an executable. One dependency less ...

@xzyfer
Copy link
Contributor Author

xzyfer commented Aug 24, 2015

Would child_process.exec work for our tests and running git

Good question. I have not tested. I see no issue sticking with cross-spawn it's well maintained, and very small.

xzyfer added a commit to xzyfer/node-sass that referenced this issue Aug 31, 2015
@xzyfer
Standardise on cross-spawn for spawning child processes
33b3a66 
There a known issues with `spawn` on Windows i.e. nodejs/node-v0.x-archive#2318.
As a work around we sometimes use
[cross-spawn](https://www.npmjs.com/package/cross-spawn). We will
move all usage of `spawn` to `cross-spawn`.
Closes sass#1015.
@xzyfer xzyfer mentioned this issue Aug 31, 2015
Merged
@xzyfer xzyfer modified the milestones: next.patch, v3.3.3 Sep 17, 2015
This was referenced Oct 16, 2015
Merged
Closed
Closed
Closed
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
@xzyfer
Merge pull request sass#1015 from xzyfer/fix/remove-debugger-from-cov…
d215db5 
…erage

Fix typo in code coverage config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Community - Help Wanted Feature - Request npm build OS - Windows
Projects
None yet
Milestone
v3.3.3
Development

No branches or pull requests
2 participants
@saper @xzyfer