This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Replace pangyp with node-gyp #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
feat/node-gyp
branch
from
c41d753
to
3845449
Compare
|
This is not strictly necessary for 4.x if one supplies node headers to compile. I have some issues recently with gyp variables, looks like a variant of nodejs/node-gyp#26. Will be tracking this down and posting upstream. |
Closed
We originally adopted pangyp as a tempory work around for iojs support. This and more has been added to node-gyp and as such pangyp has been deprecated.
xzyfer
force-pushed
the
feat/node-gyp
branch
from
3845449
to
35aa6dd
Compare
This was referenced Oct 16, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally adopted pangyp as a tempory work around for iojs support. This and more has been added to node-gyp and as such pangyp has been deprecated.
As far as I can tell this is all that's needed. My guess is we'll need to generated the bindings so lets ship this when we ship the node@4 bindings.
Closes #1124