Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Prepare libsass 3.3: fix tests and build parameters #1146

Merged
merged 3 commits into from
Sep 16, 2015
Merged

Prepare libsass 3.3: fix tests and build parameters #1146

merged 3 commits into from
Sep 16, 2015

Conversation

saper
Copy link
Member

@saper saper commented Sep 16, 2015

Those changes are not affecting libsass 3.2.5
and can be merged before libsass 3.3 hits the tree.

@saper
Test against a hopefully correct source map output
2571f9e 
Introduce libsass version checking in cli.js
and skip the test if running with libsass 3.2.5
or older.
@saper
includedFiles returns an array in no particular order
9d83b9a 
Fixes: sass#1123
@saper
Exclude -DDEBUG from the libsass build
5c10de5 
If compiling using the debug build of node
-DDEBUG and -D_DEBUG flags are automatically
added.

This causes libsass to produce additional
debugging output that may interfere with
tests.

Once this is resolved, this can be reverted.

Reported-as: sass/libsass#1518
@saper saper mentioned this pull request Sep 16, 2015
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Sep 16, 2015

👍🚢
On 16 Sep 2015 19:49, "Marcin Cieślak" [email protected] wrote:

Those changes are not affecting libsass 3.2.5

and can be merged before libsass 3.3 hits the tree.

You can view, comment on, or merge this pull request online at:

#1146
Commit Summary

  • Test against a hopefully correct source map output
  • includedFiles returns an array in no particular order
  • Exclude -DDEBUG from the libsass build

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#1146.

@saper saper added this to the next.libsass milestone Sep 16, 2015
@saper saper self-assigned this Sep 16, 2015
@saper saper merged commit 5c10de5 into sass:master Sep 16, 2015
This was referenced Oct 16, 2015
Merged
Closed
Closed
Closed
@xzyfer xzyfer modified the milestone: next.libsass Oct 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@saper saper

Labels
npm build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saper @xzyfer