This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
WIP: feat: Remove deprecated request package in favor of axios #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to Axios as the request module is deprecated since February 2020
|
This pull request introduces 2 alerts when merging 66fd9d3 into 1bab0ad - view on LGTM.com new alerts:
|
| @@ -9,6 +9,7 @@ var fs = require('fs'), | |||
| sass = require('../lib/extensions'), | |||
| request = require('request'), | |||
|
You've added yarn.lock (by accident?). |
|
I added yarn.lock because I use yarn as a package manager. I will remove it once the PR is ready to merge. |
|
Check #2851, |
|
Okay it seems that make-fetch-happen should be used. If that decision is final I'd like to create a PR for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As request was deprecated at the begin of this year I thought it would be good if it would get replaced.
The functionality is already ported to axios but I have some issues with the tests. Would be great if somebody could assist me there.