feat: Node 18 and 19 support and drop Node 17 #3257

nschonni · 2022-04-19T16:33:58Z

Fixes #3251
Still needs Node Docker image release before this will pass

nschonni · 2022-04-19T16:42:15Z

@xzyfer should I just drop the Docker/Alpine part for now so this can just land? It's been flaky for awhile on the previous releases anyway.
I picked v8 instead of 7.1, but that can be updated too

xzyfer · 2022-05-04T04:49:01Z

My hero

nschonni · 2022-05-31T19:15:34Z

Looks like x86 should be good in 18.3.0 nodejs/build#2956 and Node 17 is EOL tomorrow.
@xzyfer would it make sense to push out a release after those 2 things?

rasmustoender · 2022-06-03T10:37:34Z

@xzyfer would be awesome to have this reviewed soon! :)

John-H-Smith · 2022-07-05T09:23:22Z

News about that?

gengjiawen · 2022-07-12T09:51:32Z

@nschonni Can you merge this ? thx

gengjiawen · 2022-07-12T09:58:08Z

We may need to bump nan version

npm ERR! /Users/daniel/Library/Caches/node-gyp/18.4.0/include/node/v8config.h:460:35: note: expanded from macro 'V8_DEPRECATED'
npm ERR! # define V8_DEPRECATED(message) [[deprecated(message)]]
npm ERR!                                   ^
npm ERR! In file included from ../src/binding.cpp:1:
npm ERR! In file included from ../../nan/nan.h:2818:
npm ERR! ../../nan/nan_typedarray_contents.h:34:43: error: no member named 'GetContents' in 'v8::ArrayBuffer'
npm ERR!       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;

reynldi · 2022-07-24T15:49:42Z

Any update ? For how long we need to wait this PR ?

eduardocque · 2022-08-11T12:13:11Z

+1

alexgwolff · 2022-09-14T20:20:33Z

Hi, any update?

eduardocque · 2022-10-01T08:01:31Z

Hi, any updates about this @nschonni

Regards

chrishough · 2022-10-12T04:18:42Z

+1

hanorine · 2022-10-21T20:48:30Z

Would love to see this merged in too. Hoping this package is still maintained. +1

nholden-re · 2022-11-03T18:04:30Z

Now that Node 18 is the active LTS, can we please get this PR some traction?

wratho · 2022-11-07T19:34:53Z

Really would like to hear an update on the state of Node 18. currently blocked from progressing without it.

Shane32 · 2022-11-08T01:22:03Z

If not a final release, could a beta release be published with node 18 support?

xzyfer

Master should be fixed now and nan and node-gyp have been updated to support node 19.

reynldi · 2022-11-08T11:23:57Z

Master should be fixed now and nan and node-gyp have been updated to support node 19.

Awesome !

doncem · 2022-11-09T10:05:52Z

well that took just a brief period of time 😏

xzyfer · 2022-11-09T10:38:29Z

That's on me. Apologies to everyone waiting on this release, and to @nschonni for disappearing for a little while.

Part of our release process for when adding new Node versions I still run manually offline and I was occupied with other priorities. We're looking to better automate the process for future releases.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [node-sass](https://togithub.com/sass/node-sass) | [`^6.0.0 \|\| ^7.0.0` -> `^6.0.0 \|\| ^7.0.0 \|\| ^9.0.0`](https://renovatebot.com/diffs/npm/node-sass/7.0.3/9.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/node-sass/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/node-sass/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/node-sass/7.0.3/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/node-sass/7.0.3/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sass/node-sass (node-sass)</summary> ### [`v9.0.0`](https://togithub.com/sass/node-sass/releases/tag/v9.0.0) [Compare Source](https://togithub.com/sass/node-sass/compare/v8.0.0...v9.0.0) #### What's Changed - Node 20 support by [@nschonni](https://togithub.com/nschonni) in [https://github.com/sass/node-sass/pull/3355](https://togithub.com/sass/node-sass/pull/3355) ##### Breaking changes - Drop support for Node 14 ([@nschonni](https://togithub.com/nschonni)) #### Supported Environments | OS | Architecture | Node | | --- | --- | --- | | Windows | x86 & x64 | 16, 18, 19, 20 | | OSX | x64 | 16, 18, 19, 20 | | Linux\* | x64 | 16, 18, 19, 20 | | Alpine Linux | x64 | 16, 18, 19, 20 | \*Linux support refers to major distributions like Ubuntu, and Debian ### [`v8.0.0`](https://togithub.com/sass/node-sass/releases/tag/v8.0.0) [Compare Source](https://togithub.com/sass/node-sass/compare/v7.0.3...v8.0.0) #### What's Changed - Fix binaries being partially downloaded by [@xzyfer](https://togithub.com/xzyfer) in [https://github.com/sass/node-sass/pull/3313](https://togithub.com/sass/node-sass/pull/3313) - Bump node-gyp and nan for node 19 support by [@xzyfer](https://togithub.com/xzyfer) in [https://github.com/sass/node-sass/pull/3314](https://togithub.com/sass/node-sass/pull/3314) - feat: Node 18 and 19 support and drop Node 17 by [@nschonni](https://togithub.com/nschonni) in [https://github.com/sass/node-sass/pull/3257](https://togithub.com/sass/node-sass/pull/3257) ##### Breaking changes - Drop support for Node 12 ([@nschonni](https://togithub.com/nschonni)) - Drop support for Node 17 ([@nschonni](https://togithub.com/nschonni)) - Set `rejectUnauthorized` to `true` by default ([@scott-ut](https://togithub.com/scott-ut), [#3149](https://togithub.com/sass/node-sass/issues/3149)) ##### Features - Add support for Node 18 ([@nschonni](https://togithub.com/nschonni)) - Add support for Node 19 ([@nschonni](https://togithub.com/nschonni)) - Replace `request` with `make-fetch-happen` ([@CamilleDrapier](https://togithub.com/CamilleDrapier) [@xzyfer](https://togithub.com/xzyfer), [#3193](https://togithub.com/sass/node-sass/issues/3193), [#3313](https://togithub.com/sass/node-sass/issues/3313)) ##### Dependencies - Bump [email protected] - Bump node-gyp [@9](https://togithub.com/9).0.0 - Bump nan@^2.17.0 - Bump sass-graph@^4.0.1 ##### Misc - Bump various GitHub Actions dependencies ([@nschonni](https://togithub.com/nschonni)) #### Supported Environments | OS | Architecture | Node | | --- | --- | --- | | Windows | x86 & x64 | 14, 16, 18, 19 | | OSX | x64 | 14, 16, 18, 19 | | Linux\* | x64 | 14, 16, 18, 19 | | Alpine Linux | x64 | 14, 16, 18, 19 | | FreeBSD | i386 amd64 | 12, 14 | \*Linux support refers to major distributions like Ubuntu, and Debian </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).

nschonni force-pushed the node-18 branch from 9473350 to 0f05203 Compare April 19, 2022 18:13

nschonni requested a review from xzyfer May 4, 2022 02:07

nschonni force-pushed the node-18 branch 2 times, most recently from e1bf447 to d02b7b4 Compare June 4, 2022 01:09

nschonni changed the title ~~feat: Node 18 support~~ feat: Node 18 support and drop Node 17 Jun 4, 2022

nschonni linked an issue Jun 4, 2022 that may be closed by this pull request

Drop support for Node 17 #3252

Closed

gengjiawen approved these changes Jul 12, 2022

View reviewed changes

MrMartinR mentioned this pull request Jul 12, 2022

feat: add Node 18 support parse-community/parse-dashboard#2206

Merged

5 tasks

gengjiawen mentioned this pull request Jul 14, 2022

fix: make demo compatible with node 16 and 18 preactjs/preact#3617

Merged

reynldi approved these changes Jul 24, 2022

View reviewed changes

shrihari007 approved these changes Aug 18, 2022

View reviewed changes

nschonni force-pushed the node-18 branch from d02b7b4 to 2c6b875 Compare October 23, 2022 03:33

This comment was marked as off-topic.

Sign in to view

Nic128 mentioned this pull request Nov 7, 2022

Node 18 support (module 108) #3251

Closed

7 tasks

xzyfer approved these changes Nov 8, 2022

View reviewed changes

nschonni added 3 commits November 8, 2022 17:33

feat: Node 18 support

ccce7e1

feat: drop EOL Node 17

dad8865

feat: Node 19 support

529d68a

nschonni force-pushed the node-18 branch from 2c6b875 to 529d68a Compare November 8, 2022 22:35

xzyfer changed the title ~~feat: Node 18 support and drop Node 17~~ feat: Node 18 and 19 support and drop Node 17 Nov 9, 2022

xzyfer merged commit 98e75b3 into sass:master Nov 9, 2022

nschonni deleted the node-18 branch November 9, 2022 15:18

Silverium mentioned this pull request Aug 26, 2023

Bump tough-cookie, @vue/cli-plugin-babel, @vue/cli-plugin-typescript, @vue/cli-plugin-unit-jest, @vue/cli-service, jsdom, node-sass and less Silverium/popper-vue#45

Open

reposman33 mentioned this pull request Oct 6, 2024

Bump the npm_and_yarn group with 21 updates reposman33/ofcourse#40

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Node 18 and 19 support and drop Node 17 #3257

feat: Node 18 and 19 support and drop Node 17 #3257

nschonni commented Apr 19, 2022

nschonni commented Apr 19, 2022

xzyfer commented May 4, 2022

nschonni commented May 31, 2022

rasmustoender commented Jun 3, 2022 •

edited

Loading

John-H-Smith commented Jul 5, 2022

gengjiawen commented Jul 12, 2022

gengjiawen commented Jul 12, 2022

reynldi commented Jul 24, 2022

eduardocque commented Aug 11, 2022

alexgwolff commented Sep 14, 2022

eduardocque commented Oct 1, 2022

chrishough commented Oct 12, 2022

hanorine commented Oct 21, 2022

This comment was marked as off-topic.

nholden-re commented Nov 3, 2022

wratho commented Nov 7, 2022

Shane32 commented Nov 8, 2022

xzyfer left a comment

reynldi commented Nov 8, 2022

doncem commented Nov 9, 2022

xzyfer commented Nov 9, 2022

feat: Node 18 and 19 support and drop Node 17 #3257

feat: Node 18 and 19 support and drop Node 17 #3257

Conversation

nschonni commented Apr 19, 2022

nschonni commented Apr 19, 2022

xzyfer commented May 4, 2022

nschonni commented May 31, 2022

rasmustoender commented Jun 3, 2022 • edited Loading

John-H-Smith commented Jul 5, 2022

gengjiawen commented Jul 12, 2022

gengjiawen commented Jul 12, 2022

reynldi commented Jul 24, 2022

eduardocque commented Aug 11, 2022

alexgwolff commented Sep 14, 2022

eduardocque commented Oct 1, 2022

chrishough commented Oct 12, 2022

hanorine commented Oct 21, 2022

This comment was marked as off-topic.

nholden-re commented Nov 3, 2022

wratho commented Nov 7, 2022

Shane32 commented Nov 8, 2022

xzyfer left a comment

Choose a reason for hiding this comment

reynldi commented Nov 8, 2022

doncem commented Nov 9, 2022

xzyfer commented Nov 9, 2022

rasmustoender commented Jun 3, 2022 •

edited

Loading