Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Color 4] Update tests for color.grayscale() #1850

Merged
merged 12 commits into from
Dec 20, 2022

Conversation

dvdherron
Copy link
Contributor

@dvdherron dvdherron commented Dec 9, 2022

Part of updated/new tests for color spaces.
See sass/sass#2831

@@ -22,6 +22,11 @@ a {
a {b: grayscale(#494949)}

<===> no_saturation/gray/output.css
a {
b: rgb(73, 73, 73);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nex3 You mentioned that we should typically not return a color in a different space than the color's origin space.

Should the proposal for grayscale be updated to say that legacy colors should be converted back to origin? Currently it says to return legacy colors in hsl.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it should.

@nex3
Copy link
Contributor

nex3 commented Dec 19, 2022

Removing [skip dart-sass] since this doesn't have an accompanying Dart Sass PR

@nex3 nex3 merged commit b380938 into sass:feature.color-4 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants