add new flags for comparing warning and error diffs #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorskees
commented
Mar 13, 2023
lib/test-case/test-case.ts
Outdated
| @@ -185,7 +188,7 @@ export default class TestCase { | |||
| // create a warning file | |||
| if ( | |||
| this.dir.hasFile('warning') && | |||
| this.dir.readFile('warning') && | |||
| await this.dir.readFile('warning') && | |||
There was a problem hiding this comment.
unrelated to my changes, but was giving an error-level lint. readFile returns a promise, which if not awaited will always be true in this context
nex3
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 3 new CLI flags to configure how warning and error diffs are handled.
Closes #1679