Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specific paths to be passed to js-api-spec #1917

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Allow specific paths to be passed to js-api-spec #1917

merged 3 commits into from
Jun 6, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 3, 2023

No description provided.

@nex3 nex3 requested a review from Goodwine June 3, 2023 01:51
@Goodwine
Copy link
Member

Goodwine commented Jun 3, 2023

Was this not possible before? I recall doing this and it would run only those tests:

npm run js-api-spec -- \
  --sassSassRepo $SASS_SASS_PATH \
  --sassPackage $SASS_EMBEDDED_PATH \
  js-api-spec/legacy/importer

@nex3
Copy link
Contributor Author

nex3 commented Jun 3, 2023

Nope, currently it's hard-coded.

@Goodwine
Copy link
Member

Goodwine commented Jun 5, 2023

Nope, currently it's hard-coded.

Hm, I wonder why I can filter down to specific test files (not test cases tho) with the pattern I mentioned above 🤔

@nex3
Copy link
Contributor Author

nex3 commented Jun 6, 2023

Are you thinking of the language spec runner? Because I just tried the JS API spec runner on main and it definitely didn't restrict itself to the paths I passed on the CLI.

@Goodwine
Copy link
Member

Goodwine commented Jun 6, 2023

We figured things out offline, I was in an older version, and I guess a newer version changed things a little so the way I mentioned doesn't work anymore without this PR

@nex3 nex3 merged commit c856cad into main Jun 6, 2023
@nex3 nex3 deleted the js-api-paths branch June 6, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants