Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for first class mixins #1933

Merged
merged 36 commits into from
Oct 5, 2023
Merged

add tests for first class mixins #1933

merged 36 commits into from
Oct 5, 2023

Commits on Sep 8, 2023

  1. add tests for first class mixins

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a03b8f7 View commit details
    Browse the repository at this point in the history

  2. add more apply and get-mixin tests

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    99ebbf1 View commit details
    Browse the repository at this point in the history

  3. add another content scope test

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fe8b737 View commit details
    Browse the repository at this point in the history

  4. tidy, add tests

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    634d71a View commit details
    Browse the repository at this point in the history

  5. resolve lints

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3168534 View commit details
    Browse the repository at this point in the history

  6. fix formatting

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    cb3b2d4 View commit details
    Browse the repository at this point in the history

  7. ignore libsass

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1dcde0f View commit details
    Browse the repository at this point in the history

  8. formatting

    @connorskees
    connorskees committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    7058169 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. add apply built test, update error spans

    @connorskees
    connorskees committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6dfcf9f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/sass/sass-spec into feat/fi… 

    …rst-class-mixins
    @connorskees
    connorskees committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    68d906b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. change error message for issue_1079 

    this test _shouldn't_ have a different error message as a result of the
mixin changes, but i am updating it now so that CI is green, before i
get a chance to investigate why this change is occurring.

i have verified that the change to this test is related to the changes
to mixins
    @connorskees
    connorskees committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    ee795d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. lint spec

    @connorskees
    connorskees committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f1dc81d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/sass/sass-spec into feat/fi… 

    …rst-class-mixins
    @connorskees
    connorskees committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    9384c56 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Merge branch 'main' of https://github.com/sass/sass-spec into feat/fi… 

    …rst-class-mixins
    @connorskees
    connorskees committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e6d89d9 View commit details
    Browse the repository at this point in the history

  2. bump ci 

    previous failure seems spurious? at least, it says the error lies with
npm
    @connorskees
    connorskees committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a6874bf View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. pr review

    @connorskees
    connorskees committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a203dfc View commit details
    Browse the repository at this point in the history

  2. more pr review

    @connorskees
    connorskees committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    565122a View commit details
    Browse the repository at this point in the history

  3. fix lint

    @connorskees
    connorskees committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    bdf1d4f View commit details
    Browse the repository at this point in the history

  4. ignore libsass

    @connorskees
    connorskees committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ff5560f View commit details
    Browse the repository at this point in the history

  5. add apply tests

    @connorskees
    connorskees committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    2617471 View commit details
    Browse the repository at this point in the history

  6. make more things be on a single line

    @connorskees
    connorskees committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    ad746a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. pr review

    @connorskees
    connorskees committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    ca84c9c View commit details
    Browse the repository at this point in the history

  2. add rest argument tests

    @connorskees
    connorskees committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a290209 View commit details
    Browse the repository at this point in the history

  3. use semantic placeholders in fallthrough tests

    @connorskees
    connorskees committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    84d29a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. use semantic placeholders in redeclare using test

    @connorskees
    connorskees committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2318026 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. add different rest tests, move error tests

    @connorskees
    connorskees committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    6f0fc96 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Merge branch 'main' of https://github.com/sass/sass-spec into feat/fi… 

    …rst-class-mixins
    @connorskees
    connorskees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    156da5b View commit details
    Browse the repository at this point in the history

  2. add js api mixin test

    @connorskees
    connorskees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f918847 View commit details
    Browse the repository at this point in the history

  3. use apply in test

    @connorskees
    connorskees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    36e7d78 View commit details
    Browse the repository at this point in the history

  4. bump ci 

    test ci with more prs linked in description
    @connorskees
    connorskees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    896ccf6 View commit details
    Browse the repository at this point in the history

  5. add negative assertions for mixin

    @connorskees
    connorskees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7ecf824 View commit details
    Browse the repository at this point in the history

  6. alphabetize

    @connorskees
    connorskees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2b017e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. remove faulty assertion 

    this is not true in browser environments, for some reason
    @connorskees
    connorskees committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    55fe148 View commit details
    Browse the repository at this point in the history

  2. add back instanceof assertion

    @connorskees
    connorskees committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d940acb View commit details
    Browse the repository at this point in the history

  3. use proper instanceof check

    @connorskees
    connorskees committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    b3131b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. stricter assertMixin, use toBeInstanceOf

    @connorskees
    connorskees committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7b989f0 View commit details
    Browse the repository at this point in the history