Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color 4] Update specs for color.change() #1983

Merged
merged 5 commits into from
May 2, 2024
Merged

[Color 4] Update specs for color.change() #1983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c99de9b
Rename the color.change spec directory
nex3 Apr 30, 2024
4ca2c60
Use the namespaced color.change() function and add explicit global tests
nex3 Apr 30, 2024
4a522d9
Prep for new spaces
nex3 Apr 30, 2024
9f18f1e
Add tests for new spaces
nex3 May 2, 2024
e5a3171
Split unit error tests
nex3 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 129 additions & 0 deletions spec/core_functions/color/change/a98_rgb.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
<===> red/unitless/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $red: 0.5)}

<===> red/unitless/output.css
a {
b: color(a98-rgb 0.5 0.5 0.7);
}

<===>
================================================================================
<===> red/percent/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $red: 50%)}

<===> red/percent/output.css
a {
b: color(a98-rgb 0.5 0.5 0.7);
}

<===>
================================================================================
<===> red/out_of_range/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $red: 1.2)}

<===> red/out_of_range/output.css
a {
b: color(a98-rgb 1.2 0.5 0.7);
}

<===>
================================================================================
<===> green/unitless/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $green: 0.4)}

<===> green/unitless/output.css
a {
b: color(a98-rgb 0.2 0.4 0.7);
}

<===>
================================================================================
<===> green/percent/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $green: 40%)}

<===> green/percent/output.css
a {
b: color(a98-rgb 0.2 0.4 0.7);
}

<===>
================================================================================
<===> green/out_of_range/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $green: -0.2)}

<===> green/out_of_range/output.css
a {
b: color(a98-rgb 0.2 -0.2 0.7);
}

<===>
================================================================================
<===> blue/unitless/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $blue: 0.5)}

<===> blue/unitless/output.css
a {
b: color(a98-rgb 0.2 0.5 0.5);
}

<===>
================================================================================
<===> blue/percent/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $blue: 50%)}

<===> blue/percent/output.css
a {
b: color(a98-rgb 0.2 0.5 0.5);
}

<===>
================================================================================
<===> blue/out_of_range/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $blue: 100)}

<===> blue/out_of_range/output.css
a {
b: color(a98-rgb 0.2 0.5 100);
}

<===>
================================================================================
<===> all/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $red: 0.7, $green: 0.4, $blue: 0.2)}

<===> all/output.css
a {
b: color(a98-rgb 0.7 0.4 0.2);
}

<===>
================================================================================
<===> alpha_input/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7 / 0.9), $red: 0.5)}

<===> alpha_input/output.css
a {
b: color(a98-rgb 0.5 0.5 0.7 / 0.9);
}

<===>
================================================================================
<===> alpha_arg/input.scss
@use 'sass:color';
a {b: color.change(color(a98-rgb 0.2 0.5 0.7), $red: 0.5, $alpha: 0.9)}

<===> alpha_arg/output.css
a {
b: color(a98-rgb 0.5 0.5 0.7 / 0.9);
}
129 changes: 129 additions & 0 deletions spec/core_functions/color/change/display_p3.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
<===> red/unitless/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $red: 0.5)}

<===> red/unitless/output.css
a {
b: color(display-p3 0.5 0.5 0.7);
}

<===>
================================================================================
<===> red/percent/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $red: 50%)}

<===> red/percent/output.css
a {
b: color(display-p3 0.5 0.5 0.7);
}

<===>
================================================================================
<===> red/out_of_range/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $red: 1.2)}

<===> red/out_of_range/output.css
a {
b: color(display-p3 1.2 0.5 0.7);
}

<===>
================================================================================
<===> green/unitless/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $green: 0.4)}

<===> green/unitless/output.css
a {
b: color(display-p3 0.2 0.4 0.7);
}

<===>
================================================================================
<===> green/percent/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $green: 40%)}

<===> green/percent/output.css
a {
b: color(display-p3 0.2 0.4 0.7);
}

<===>
================================================================================
<===> green/out_of_range/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $green: -0.2)}

<===> green/out_of_range/output.css
a {
b: color(display-p3 0.2 -0.2 0.7);
}

<===>
================================================================================
<===> blue/unitless/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $blue: 0.5)}

<===> blue/unitless/output.css
a {
b: color(display-p3 0.2 0.5 0.5);
}

<===>
================================================================================
<===> blue/percent/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $blue: 50%)}

<===> blue/percent/output.css
a {
b: color(display-p3 0.2 0.5 0.5);
}

<===>
================================================================================
<===> blue/out_of_range/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $blue: 100)}

<===> blue/out_of_range/output.css
a {
b: color(display-p3 0.2 0.5 100);
}

<===>
================================================================================
<===> all/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $red: 0.7, $green: 0.4, $blue: 0.2)}

<===> all/output.css
a {
b: color(display-p3 0.7 0.4 0.2);
}

<===>
================================================================================
<===> alpha_input/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7 / 0.9), $red: 0.5)}

<===> alpha_input/output.css
a {
b: color(display-p3 0.5 0.5 0.7 / 0.9);
}

<===>
================================================================================
<===> alpha_arg/input.scss
@use 'sass:color';
a {b: color.change(color(display-p3 0.2 0.5 0.7), $red: 0.5, $alpha: 0.9)}

<===> alpha_arg/output.css
a {
b: color(display-p3 0.5 0.5 0.7 / 0.9);
}
21 changes: 12 additions & 9 deletions ...nctions/color/change_color/error/args.hrx → ...ore_functions/color/change/error/args.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,43 @@
<===> too_few/input.scss
a {b: change-color()}
@use 'sass:color';
a {b: color.change()}

<===> too_few/error
Error: Missing argument $color.
,--> input.scss
1 | a {b: change-color()}
2 | a {b: color.change()}
| ^^^^^^^^^^^^^^ invocation
'
,--> sass:color
1 | @function change($color, $kwargs...) {
| ========================== declaration
'
input.scss 1:7 root stylesheet
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> too_many/input.scss
a {b: change-color(red, 1)}
@use 'sass:color';
a {b: color.change(red, 1)}

<===> too_many/error
Error: Only one positional argument is allowed. All other arguments must be passed by name.
,
1 | a {b: change-color(red, 1)}
2 | a {b: color.change(red, 1)}
| ^^^^^^^^^^^^^^^^^^^^
'
input.scss 1:7 root stylesheet
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> unknown/input.scss
a {b: change-color(red, $ambience: 10%)}
@use 'sass:color';
a {b: color.change(red, $ambience: 10%)}

<===> unknown/error
Error: $ambience: Color space rgb doesn't have a channel with this name.
,
1 | a {b: change-color(red, $ambience: 10%)}
2 | a {b: color.change(red, $ambience: 10%)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 1:7 root stylesheet
input.scss 2:7 root stylesheet
39 changes: 39 additions & 0 deletions spec/core_functions/color/change/error/bounds.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<===> alpha/too_low/input.scss
@use 'sass:color';
a {b: color.change(red, $alpha: -0.001)}

<===> alpha/too_low/error
Error: $alpha: Expected -0.001 to be within 0 and 1.
,
2 | a {b: color.change(red, $alpha: -0.001)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> alpha/too_high/input.scss
@use 'sass:color';
a {b: color.change(red, $alpha: 1.001)}

<===> alpha/too_high/error
Error: $alpha: Expected 1.001 to be within 0 and 1.
,
2 | a {b: color.change(red, $alpha: 1.001)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> alpha/unit/input.scss
@use 'sass:color';
a {b: color.change(red, $alpha: 150%)}

<===> alpha/unit/error
Error: $alpha: Expected 150% to be within 0% and 100%.
,
2 | a {b: color.change(red, $alpha: 150%)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 2:7 root stylesheet
39 changes: 39 additions & 0 deletions spec/core_functions/color/change/error/incompatible_channel.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<===> legacy_space/input.scss
@use 'sass:color';
a {b: color.change(red, $chroma: 50%)}

<===> legacy_space/error
Error: $chroma: Color space rgb doesn't have a channel with this name.
,
2 | a {b: color.change(red, $chroma: 50%)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> legacy_channel/input.scss
@use 'sass:color';
a {b: color.change(color(srgb 0.2 0.5 0.7), $whiteness: 50%)}

<===> legacy_channel/error
Error: $whiteness: Color space srgb doesn't have a channel with this name.
,
2 | a {b: color.change(color(srgb 0.2 0.5 0.7), $whiteness: 50%)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 2:7 root stylesheet

<===>
================================================================================
<===> modern_both/input.scss
@use 'sass:color';
a {b: color.change(color(srgb 0.2 0.5 0.7), $chroma: 50%)}

<===> modern_both/error
Error: $chroma: Color space srgb doesn't have a channel with this name.
,
2 | a {b: color.change(color(srgb 0.2 0.5 0.7), $chroma: 50%)}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'
input.scss 2:7 root stylesheet
Loading
Loading