Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mixed-decl tests to reflect the improved implementation #2014

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Update mixed-decl tests to reflect the improved implementation #2014

merged 4 commits into from
Sep 13, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 13, 2024

[skip dart-sass]

@nex3 nex3 requested a review from Goodwine September 13, 2024 01:58
@nex3 nex3 mentioned this pull request Sep 13, 2024
Merged
Goodwine
Goodwine approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but only one question. I think it's covered by the :where() test, but just trying to make sure

spec/css/style_rule.hrx Outdated Show resolved Hide resolved
@nex3 nex3 merged commit 5d57580 into main Sep 13, 2024
12 checks passed
@nex3 nex3 deleted the mixed-decls-improvement branch September 13, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @Goodwine