Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post signature #38

Merged
merged 6 commits into from
Aug 10, 2020
Merged

Post signature #38

merged 6 commits into from
Aug 10, 2020

Conversation

katerynabugaieva
Copy link
Contributor

@katerynabugaieva katerynabugaieva commented Aug 6, 2020 •
edited
Loading

This PR about adding signature for posts and date

Update: add author summary (design will be corrected by Verena soon)
Screenshot 2020-08-07 at 12 13 31

@georgiee
Copy link
Member

georgiee commented Aug 6, 2020

Just checked the errors. Install fails because of npm https://status.npmjs.org/incidents/cksjqc1w11v5

feedm3
feedm3 requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@feedm3 feedm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, I like it 👍 The structure of the component is simple and clear and the tests are good. Just some small improvements, then it's good to go 🚀

src/components/signature/signature.tsx Outdated Show resolved Hide resolved
src/components/signature/signature.tsx Outdated Show resolved Hide resolved
src/components/signature/signature.test.tsx Outdated Show resolved Hide resolved
georgiee
georgiee approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@georgiee georgiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

Later/Ideas:
I would consider to move the signature (or byline as suggested) to the top (more accessible?) and include an optional summary of the author (Frontend Engineer at Satellytes or so). Can we check if those suggestions make sense? Does this need a design change? Please align with @feedm3

src/components/signature/signature.test.tsx Outdated Show resolved Hide resolved
src/components/signature/signature.test.tsx Outdated Show resolved Hide resolved
src/components/signature/signature.tsx Outdated Show resolved Hide resolved
src/templates/blog-post.tsx Outdated Show resolved Hide resolved
@katerynabugaieva katerynabugaieva self-assigned this Aug 6, 2020
@katerynabugaieva katerynabugaieva mentioned this pull request Aug 10, 2020
Merged
feedm3
feedm3 requested changes Aug 10, 2020
View reviewed changes
src/templates/blog-post.tsx Outdated Show resolved Hide resolved
feedm3
feedm3 requested changes Aug 10, 2020
View reviewed changes
src/templates/blog-post.tsx Outdated Show resolved Hide resolved
@katerynabugaieva katerynabugaieva merged commit 85224b1 into main Aug 10, 2020
@katerynabugaieva katerynabugaieva deleted the post-signature branch August 10, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgiee georgiee georgiee approved these changes

@feedm3 feedm3 feedm3 approved these changes

Assignees

@katerynabugaieva katerynabugaieva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katerynabugaieva @georgiee @feedm3