-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (a11y): breadcrumb a11y issues on blog page #805
base: main
Are you sure you want to change the base?
Conversation
… 0, 0.65) to make color contrast WCAG AA compliant fix: add aria-label and roll to breadcrumb container fix: remove overflow: hidden from BreadcrumbContainer to prevent focus outline cutoff
✅ Deploy Preview for satellytes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for that.
It would help if you can describe the effects in addition to the changes because a11y is pretty abstract for many folks. Even with some experience I've issues following the actual motivation for your changes
I found two issues while the color change is good.
- I can see the difference with the colour and I understand the contrast thing. Fine!
- I do not understand the role "navigation" because that seems to remove the list + listitem role already given by the
ol
tag. I think a better alternative would be to just wrap theol
with an additionalnav
tag. That way people can use the semantics of the list (screen reader more easily navigate lists) plus the nav semantic, that a screen reader may use to tell about the significant navigation options on the page
Ref:
- https://a11y-style-guide.com/style-guide/section-navigation.html
- https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/navigation_role
- I don't see any difference of the focus outline. Can you demonstrate? I also wonder why removing the overflow has no other impact. Why do we have it in the first place anyway?
You see that I have feedback to all three changes. I have the vague feeling that 3 very small PRs would have been much better here as you could focus on documenting and demonstrating the purpose of the change. On the other hand, it's quite an overhead. Let's go with this PR, fix the issues and then continue.
Chages:
overflow: hidden
withoverflow-x: clip
to only hide the overflow in the x directionpadding: 0
withpadding-left: 4px
so the outline isn't cut of at the left sidetransform: translateX(-4px)
to breadcrumb container to counteract the visual changes through the padding changedisplay: inline-block
to the breadcrumb link to fix the shape of the focus outlineBefore:
After (without
display: inline-block
added ):