This repository has been archived by the owner on May 8, 2024. It is now read-only.
Upgrade to 0.60.4 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade test dependencies - add visual regression testing including script - add images - clean up configs
- upgrade for iOS, only for login screen
- upgrade for Android
- fix Android splash screen - fix Android icons - fix Android fonts
- add new webview component
- fix router header
- fix linting - fix Android release build
- fix linting by adding a hook
- fix Webview for Android - fix layout for all components - add a close button translation - add Appium to the services - fix iOS config - add fix for Android accessibilityLabels, due to an issue on React Native - fix tests - fix readme
- fix Android fonts - fix visual tests
wswebcreation
requested review from
rslobojan-saucelabs,
richard-sl,
tboyles-sl and
ryanveselysauce
rslobojan-saucelabs
suggested changes
Aug 1, 2019
|
As said, thanks for taking the time to review it. I fixed the changes and updated the comment, can you please take a look and if you agree resolve the last remark? |
rslobojan-saucelabs
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the big ass PR, but this one was needed for the following reasons:
testsandsrcfolders )So, basically, everything changed 😆
I'm on holiday as of now, so take your time. When this is merged I will make new releases for the Sauce Labs users and customers and will upload it here https://github.com/saucelabs/sample-app-mobile/releases
That was it, happy checking!