Adding new logic for suppressing inspection #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1328 +/- ##
============================================
- Coverage 82.08% 82.01% -0.08%
Complexity 2538 2538
============================================
Files 105 105
Lines 7223 7239 +16
Branches 2065 2071 +6
============================================
+ Hits 5929 5937 +8
- Misses 346 354 +8
Partials 948 948
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: - ignoreAnnotated logic - adding suppressing for ALL rules for the code block
orchestr7
force-pushed
the
feature/ignoreAnnotated
branch
from
553898b
to
48cfdbd
Compare
### What's done:
- ignoreAnnotated logic to disable annotated code blocks
- adding mechanism for suppression of ALL rules for the selected code block with Suppress("diktat")
### What's done:
- ignoreAnnotated logic to disable annotated code blocks
- adding mechanism for suppression of ALL rules for the selected code block with Suppress("diktat")
### What's done: - diktat fixes
…ature/ignoreAnnotated # Conflicts: # diktat-common/src/main/kotlin/org/cqfn/diktat/common/config/rules/RulesConfigReader.kt
### What's done: - detekt fixes
### What's done: - detekt fixes
orchestr7
force-pushed
the
feature/ignoreAnnotated
branch
from
5814edb
to
f6f4cb1
Compare
petertrr
approved these changes
May 30, 2022
| @@ -12,6 +12,8 @@ | |||
| # Checks that the Class/Enum/Interface name does not match Pascal case | |||
| - name: CLASS_NAME_INCORRECT | |||
| enabled: true | |||
| # all code blocks with MyAnnotation will be ignored and not checked | |||
| ignoreAnnotated: [ MyAnnotation ] | |||
There was a problem hiding this comment.
This file will be bundled into the jar, is it worth adding this here and not into examples?
There was a problem hiding this comment.
I see that users copy-paste this one 🤦
But yes, let's remove
Co-authored-by: Peter Trifanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
ignoreAnnotatedlogic that helps to suppress inspections that could have triggered on the block of code annotated with some specific annotations (useful for Jetpack)