Don't separate fully-qualified as a regular dot qualified expression
#1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add analytic fully-qualified * add test * correct warning message ## Issue (#1403)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Fixed
Show fixed
Hide fixed
* add analytic fully-qualified * add test * correct warning message * run fix mode ## Issue (#1403)
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
============================================
+ Coverage 83.38% 83.39% +0.01%
- Complexity 2552 2557 +5
============================================
Files 106 106
Lines 7570 7575 +5
Branches 2086 2087 +1
============================================
+ Hits 6312 6317 +5
Misses 372 372
Partials 886 886
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
reviewed
Jun 28, 2022
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/files/NewlinesRuleWarnTest.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
* add analytic fully-qualified * add test * correct warning message * run fix mode ## Issue (#1403)
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Fixed
Show fixed
Hide fixed
petertrr
reviewed
Jun 28, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
added 2 commits
June 28, 2022 18:48
petertrr
approved these changes
Jun 28, 2022
nulls
reviewed
Jun 29, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Outdated
Show resolved
Hide resolved
petertrr
reviewed
Jun 29, 2022
There was a problem hiding this comment.
@Arrgentum please check #1411 (comment) and also please rename this PR to something more meaningful and pay attention to the text of merge commit
Arrgentum
changed the title
dot qualified expression
* Add logic fully-qualified: not split `dot qualified expression` before first `call expression` * Add 1 fix test and 5 test examples * Correct warning message * run fix mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats added
Add analytic fully qualified - split long
dot qualified expressionandsafe access expressionand and their combinations after firstcall expressionThis pull request closes #1403
Actions checklist
long dot qualified expression