Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-plugin: fix docs and tests for Groovy DSL #1428

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jul 6, 2022

What's done:

  • Update build.gradle in examples
  • Add functional test for Groovy DSL with explicit inputs
  • Fix docs for diktatExtension.output: reporter treats any non-empty string as a file name, there are no special values
  • Remove dependsOn relation between test and functionalTest, use shouldRunAfter instead

This pull request closes #1422

### What's done:
* Update build.gradle in examples
* Add test for Groovy DSL with explicit inputs
* Minor cleanup in gradle-plugin's docs
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1428 (62723a1) into master (0cd6d17) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1428      +/-   ##
============================================
- Coverage     83.34%   83.19%   -0.15%     
+ Complexity     2562     2555       -7     
============================================
  Files           107      107              
  Lines          7612     7612              
  Branches       2103     2103              
============================================
- Hits           6344     6333      -11     
- Misses          376      388      +12     
+ Partials        892      891       -1     
Flag Coverage Δ
unittests 83.19% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt 100.00% <ø> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 74.10% <0.00%> (-9.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd6d17...62723a1. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 271 tests   1 256 ✔️  1m 26s ⏱️
   156 suites       15 💤
   156 files           0

Results for commit 98a2b50.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 271 tests   1 256 ✔️  1m 0s ⏱️
   156 suites       15 💤
   156 files           0

Results for commit 98a2b50.

♻️ This comment has been updated with latest results.

@petertrr petertrr enabled auto-merge (squash) July 8, 2022 08:06
@petertrr petertrr merged commit 739bd3a into master Jul 8, 2022
@petertrr petertrr deleted the bugfix/diktat-gradle-plugin-groovy#1442 branch July 8, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle plug-in: unable to specify inputs if Groovy DSL is used
2 participants