Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trim() for list of string test directories #1537

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

Cheshiriks
Copy link
Member

What's done:
added trim() for list of string test directories
Closes #1288

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1537 (96a28c0) into master (3beabb0) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1537      +/-   ##
============================================
+ Coverage     83.01%   83.02%   +0.01%     
  Complexity     2363     2363              
============================================
  Files           111      111              
  Lines          7760     7760              
  Branches       2009     2009              
============================================
+ Hits           6442     6443       +1     
+ Misses          439      436       -3     
- Partials        879      881       +2     
Flag Coverage Δ
unittests 83.02% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 35.71% <0.00%> (+1.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

1 938 tests   1 923 ✔️  3m 8s ⏱️
   160 suites       15 💤
   160 files           0

Results for commit 96a28c0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

1 923 tests   1 908 ✔️  1m 25s ⏱️
   159 suites       15 💤
   159 files           0

Results for commit 96a28c0.

♻️ This comment has been updated with latest results.

### What's done:
* Added trim() for list of string test directories
Closes #1288
@Cheshiriks Cheshiriks merged commit 0046681 into master Oct 28, 2022
@Cheshiriks Cheshiriks deleted the feature/add-trim-for-testDirs branch October 28, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RulesConfigReader does not remove whitespaces for testDirs
2 participants