-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed VARIABLE_NAME_INCORRECT_FORMAT
false positive when a property has a backing field
#1810
Conversation
- fixed warning `VARIABLE_NAME_INCORRECT_FORMAT` on `backing field`. - added warning test. Closes #1711
Does it close #1709 as well? |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 164 files - 1 164 suites - 1 8m 49s ⏱️ + 1m 36s Results for commit d84c98c. ± Comparison against base commit 81a7429. This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 164 files - 1 164 suites - 1 6m 44s ⏱️ -13s Results for commit d84c98c. ± Comparison against base commit 81a7429. This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1810 +/- ##
============================================
- Coverage 78.77% 78.72% -0.05%
- Complexity 2430 2441 +11
============================================
Files 126 126
Lines 8526 8544 +18
Branches 2150 2163 +13
============================================
+ Hits 6716 6726 +10
Misses 850 850
- Partials 960 968 +8 ☔ View full report in Codecov by Sentry. |
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter1/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
...at-rules/src/test/kotlin/com/saveourtool/diktat/ruleset/chapter1/IdentifierNamingWarnTest.kt
Show resolved
Hide resolved
...-rules/src/test/kotlin/com/saveourtool/diktat/ruleset/chapter6/CustomGetterSetterWarnTest.kt
Outdated
Show resolved
Hide resolved
- added `ASTNode.isCorrectBackingField(ASTNode)` method. - added warning tests, which trigger on incorrect `backing field` format. Closes #1711
No |
What's done:
VARIABLE_NAME_INCORRECT_FORMAT
onbacking field
.Closes #1711