-
Notifications
You must be signed in to change notification settings - Fork 150
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- fix multiple cookie headers support for excon and http adapter - fix SSLError error handling for http connector - add inegration tests for excon and http adapters
- Loading branch information
Piotr Boniecki
committed
Jan 11, 2017
1 parent
4aed534
commit fab302a
Showing
4 changed files
with
228 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
require "spec_helper" | ||
require "integration/support/server" | ||
|
||
describe HTTPI::Adapter::HTTPClient do | ||
|
||
subject(:adapter) { :excon } | ||
|
||
context "http requests" do | ||
before :all do | ||
@server = IntegrationServer.run | ||
end | ||
|
||
after :all do | ||
@server.stop | ||
end | ||
|
||
it "sends and receives HTTP headers" do | ||
request = HTTPI::Request.new(@server.url + "x-header") | ||
request.headers["X-Header"] = "HTTPI" | ||
|
||
response = HTTPI.get(request, adapter) | ||
expect(response.body).to include("HTTPI") | ||
end | ||
|
||
it "it supports headers with multiple values" do | ||
request = HTTPI::Request.new(@server.url + "cookies") | ||
|
||
response = HTTPI.get(request, adapter) | ||
cookies = ["cookie1=chip1; path=/", "cookie2=chip2; path=/"] | ||
expect(response.headers["Set-Cookie"]).to eq(cookies) | ||
end | ||
|
||
it "executes GET requests" do | ||
response = HTTPI.get(@server.url, adapter) | ||
expect(response.body).to eq("get") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes POST requests" do | ||
response = HTTPI.post(@server.url, "<some>xml</some>", adapter) | ||
expect(response.body).to eq("post") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes HEAD requests" do | ||
response = HTTPI.head(@server.url, adapter) | ||
expect(response.code).to eq(200) | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes PUT requests" do | ||
response = HTTPI.put(@server.url, "<some>xml</some>", adapter) | ||
expect(response.body).to eq("put") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes DELETE requests" do | ||
response = HTTPI.delete(@server.url, adapter) | ||
expect(response.body).to eq("delete") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "supports basic authentication" do | ||
request = HTTPI::Request.new(@server.url + "basic-auth") | ||
request.auth.basic("admin", "secret") | ||
|
||
response = HTTPI.get(request, adapter) | ||
expect(response.body).to eq("basic-auth") | ||
end | ||
|
||
it "supports chunked response" do | ||
request = HTTPI::Request.new(@server.url) | ||
res = "" | ||
request.on_body do |body| | ||
res += body | ||
end | ||
response = HTTPI.post(request, adapter) | ||
expect(res).to eq("post") | ||
expect(response.body).to eq("") | ||
end | ||
end | ||
|
||
if RUBY_PLATFORM =~ /java/ | ||
pending "Puma Server complains: SSL not supported on JRuby" | ||
else | ||
context "https requests" do | ||
before :all do | ||
@server = IntegrationServer.run(:ssl => true) | ||
end | ||
after :all do | ||
@server.stop | ||
end | ||
|
||
it "raises when no certificate was set up" do | ||
expect { HTTPI.post(@server.url, "", adapter) }.to raise_error(HTTPI::SSLError) | ||
end | ||
|
||
it "works when set up properly" do | ||
request = HTTPI::Request.new(@server.url) | ||
request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file | ||
|
||
response = HTTPI.get(request, adapter) | ||
expect(response.body).to eq("get") | ||
end | ||
end | ||
end | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
require "spec_helper" | ||
require "integration/support/server" | ||
|
||
describe HTTPI::Adapter::HTTP do | ||
|
||
subject(:adapter) { :http } | ||
|
||
context "http requests" do | ||
before :all do | ||
@server = IntegrationServer.run | ||
end | ||
|
||
after :all do | ||
@server.stop | ||
end | ||
|
||
it "sends and receives HTTP headers" do | ||
request = HTTPI::Request.new(@server.url + "x-header") | ||
request.headers["X-Header"] = "HTTPI" | ||
|
||
response = HTTPI.get(request, adapter) | ||
expect(response.body).to include("HTTPI") | ||
end | ||
|
||
it "it supports headers with multiple values" do | ||
request = HTTPI::Request.new(@server.url + "cookies") | ||
|
||
response = HTTPI.get(request, adapter) | ||
cookies = ["cookie1=chip1; path=/", "cookie2=chip2; path=/"] | ||
expect(response.headers["Set-Cookie"]).to eq(cookies) | ||
end | ||
|
||
it "executes GET requests" do | ||
response = HTTPI.get(@server.url, adapter) | ||
expect(response.body).to eq("get") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes POST requests" do | ||
response = HTTPI.post(@server.url, "<some>xml</some>", adapter) | ||
expect(response.body).to eq("post") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes HEAD requests" do | ||
response = HTTPI.head(@server.url, adapter) | ||
expect(response.code).to eq(200) | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes PUT requests" do | ||
response = HTTPI.put(@server.url, "<some>xml</some>", adapter) | ||
expect(response.body).to eq("put") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "executes DELETE requests" do | ||
response = HTTPI.delete(@server.url, adapter) | ||
expect(response.body).to eq("delete") | ||
expect(response.headers["Content-Type"]).to eq("text/plain") | ||
end | ||
|
||
it "supports basic authentication" do | ||
request = HTTPI::Request.new(@server.url + "basic-auth") | ||
request.auth.basic("admin", "secret") | ||
|
||
response = HTTPI.get(request, adapter) | ||
expect(response.body).to eq("basic-auth") | ||
end | ||
|
||
it "supports chunked response" do | ||
skip("Needs investigation") | ||
request = HTTPI::Request.new(@server.url) | ||
res = "" | ||
request.on_body do |body| | ||
res += body | ||
end | ||
response = HTTPI.post(request, adapter) | ||
expect(res).to eq("post") | ||
expect(response.body).to eq("") | ||
end | ||
end | ||
|
||
if RUBY_PLATFORM =~ /java/ | ||
pending "Puma Server complains: SSL not supported on JRuby" | ||
else | ||
context "https requests" do | ||
before :all do | ||
@server = IntegrationServer.run(:ssl => true) | ||
end | ||
after :all do | ||
@server.stop | ||
end | ||
|
||
it "raises when no certificate was set up" do | ||
expect { HTTPI.post(@server.url, "", adapter) }.to raise_error(HTTPI::SSLError) | ||
end | ||
|
||
it "works when set up properly" do | ||
request = HTTPI::Request.new(@server.url) | ||
request.auth.ssl.ca_cert_file = IntegrationServer.ssl_ca_file | ||
|
||
response = HTTPI.get(request, adapter) | ||
expect(response.body).to eq("get") | ||
end | ||
end | ||
end | ||
|
||
end |