Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we remove socksify as a dependency? #224

Closed
ioquatix opened this issue Oct 5, 2021 · 3 comments · Fixed by #225
Closed

Can we remove socksify as a dependency? #224

ioquatix opened this issue Oct 5, 2021 · 3 comments · Fixed by #225

Comments

@ioquatix
Copy link
Contributor

ioquatix commented Oct 5, 2021

httpi/httpi.gemspec

Line 19 in 497a304

s.add_dependency 'socksify'

It would be awesome if we can make this an optional dependency because we are concerned about thread safety issues it might introduce - and also it looks abandoned.
@olleolleolle
Copy link
Contributor

Sure, I think we can! People who need it, they can get a nice message about what they need to do.

Would you be interested in making a PR?

@ioquatix
Copy link
Contributor Author

ioquatix commented Oct 5, 2021

Haha, it's you!

What a small world.

Okay, sure, PR will be en-route.

This was referenced Oct 5, 2021
Closed
Merged
@ioquatix
Copy link
Contributor Author

At some point can we please cut a major release with this? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make socksify and rack gem dependencies optional ioquatix/httpi
2 participants
@olleolleolle @ioquatix