Make socksify and rack gem dependencies optional #225
Conversation
ioquatix
force-pushed
the
update-and-rework-gem-dependencies
branch
2 times, most recently
from
9e25a26
to
650b037
Compare
ioquatix
force-pushed
the
update-and-rework-gem-dependencies
branch
from
83f391e
to
2ed09a9
Compare
|
I am frantically pushing APPROVE AND RUN |
ioquatix
force-pushed
the
update-and-rework-gem-dependencies
branch
5 times, most recently
from
8f41b40
to
e9057fd
Compare
spec/httpi/httpi_spec.rb
Outdated
| @@ -294,7 +292,7 @@ | |||
| end | |||
|
|
|||
| HTTPI::Adapter::ADAPTERS.each do |adapter, opts| | |||
| unless (adapter == :em_http && RUBY_VERSION =~ /1\.8/) || (adapter == :curb && RUBY_PLATFORM =~ /java/) | |||
| unless (adapter == :em_http || adapter == :curb) && RUBY_PLATFORM =~ /java/ | |||
There was a problem hiding this comment.
As mentioned, a platform-to-adapters-supported-on-that-platform could be interesting.
There was a problem hiding this comment.
Yeah this was a quick hack to get it passing since it's already 1AM lol.
There was a problem hiding this comment.
All in due time, that's a note for future PRs.
|
So, I think this is at the place where we need to look at things we can extract from it, and offer to the default branch. A way forward with this big a change is a new major version, which allows to shed old version support etc. |
|
In addition to the earlier things fixed, the CI issue is also fixed by this. |
ioquatix
force-pushed
the
update-and-rework-gem-dependencies
branch
from
a797a27
to
e777d2f
Compare
olleolleolle
changed the title
|
Thank you for your work on this. |
|
This has now been released as 3.0.0. https://github.com/savonrb/httpi/releases/tag/v3.0.0 |
|
Thank you so much. |
Fixes #224. Fixes #205.