Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems really weird to me. Is there a reason why the rubyntlm gem doesn't require its own version file itself when you require 'net/ntlm'? Seems very odd that anyone using ntlm would need to require that themselves.
Also, is there a reason to guard against doing this when the constant is already defined?
Sorry for all of the questions, I'm just curious -- I don't normally see a lot of ruby in this style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why
rubyntlm
v0.4.0 doesn't require its own version constant. It was moved there pretty recently and is required explicitly by the gemspec.The guard against the constant already defined is to make sure this also works with
rubyntlm
v0.3.x, which defines VERSION in net/ntlm and does not have a net/ntlm/version file, so this require would fail without the guard in 0.3.x.I don't know if I like this style either, but since it was broken in 0.4.0 this was a simple solution to work with both versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh well that's really annoying. Thanks for the quick response @carlzulauf. Looks like this is the best choice for compatibility between v0.3 and v0.4.