Don't warn about missing rubyntlm gem if it is optional #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems eminently reasonable; there's been some well natured grumbling about the debug log, which I think is understandable. After all, only a tiny fraction of users will ever care about NTLM. |
tjarratt
added a commit
that referenced
this pull request
Jul 9, 2014
Don't warn about missing rubyntlm gem if it is optional
|
Thanks @PChambino! |
|
@tjarratt any chance we could get a new minor release for this? :) |
|
Sorry for the late, the new version is finally released! Thanks everybody! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And raise
NotSupportedErrorwhen trying to authenticate with NTLM and the gem is missing.If you removed/commented the rubyntlm gem from the gemspec the test about the missing gem would fail which is strange, like this only the one that actually needs the gem fails. This makes a lot more sense to me.