Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http.rb support. #145

Merged
merged 1 commit into from
Apr 30, 2015
Merged

Conversation

Connorhd
Copy link
Contributor

Seems pretty straightforward, let me know if I need to make any changes to get this merged.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.75%) to 69.84% when pulling ad173e2 on Connorhd:add-http-rb-support into bf28a13 on savonrb:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.75%) to 69.84% when pulling ad173e2 on Connorhd:add-http-rb-support into bf28a13 on savonrb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.75%) to 69.84% when pulling ad173e2 on Connorhd:add-http-rb-support into bf28a13 on savonrb:master.

@rogerleite
Copy link
Member

Thanks @Connorhd ! Looks very good 👌

@tjarratt i'm waiting your approval. We need to remember to update the documentation site too.

@tjarratt
Copy link
Contributor

Looks great! No reason to wait for my approval, though :)

I still haven't heard back from @rubiii about how he had been updating httpirb.com (or savonrb.com either!), so I'll try reaching out to him.

tjarratt added a commit that referenced this pull request Apr 30, 2015
@tjarratt tjarratt merged commit 3f0197f into savonrb:master Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants