Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSL protocols supported by curb adapter #201

Closed
wants to merge 1 commit into from
Closed

Fix SSL protocols supported by curb adapter #201

wants to merge 1 commit into from

Conversation

907th
Copy link

@907th 907th commented Dec 13, 2018

  • Use Curl:: consts instead of magic numbers.
  • Fix invalid values of TLSv1_1 and TLSv1_2 constants.
  • Add support for TLSv1_0.

Fix SSL protocols supported by curb adapter
cee2b96 
* Use Curl:: consts instead of *magic* numbers.
* Fix invalid values of TLSv1_1 and TLSv1_2 constants.
* Add support for TLSv1_0.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b96 on 907th:fix_curb_ssl_versions into 2fbd6b1 on savonrb:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b96 on 907th:fix_curb_ssl_versions into 2fbd6b1 on savonrb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b96 on 907th:fix_curb_ssl_versions into 2fbd6b1 on savonrb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b96 on 907th:fix_curb_ssl_versions into 2fbd6b1 on savonrb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b96 on 907th:fix_curb_ssl_versions into 2fbd6b1 on savonrb:master.

@rogerleite rogerleite self-requested a review January 21, 2019 11:32
@rogerleite
Copy link
Member

Hi @907th. Thanks for opening this PR. Seems good to merge.

@rogerleite rogerleite mentioned this pull request Apr 27, 2019
Closed
@rogerleite
Copy link
Member

Forgot this PR sorry.
This code is going to conflict with #208. 🤔

@ioquatix
Copy link
Contributor

ioquatix commented Oct 6, 2021

Can you please rebase on master? Thanks!

@907th
Copy link
Author

907th commented Dec 2, 2023

I'm closing stale issue.

@907th 907th closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerleite rogerleite Awaiting requested review from rogerleite

Assignees

@907th 907th

Labels
improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@907th @coveralls @rogerleite @ioquatix