Header "Cookie" can erroneously be nil (not missing) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no cookies, the "Cookies" key shouldn't exist. The existing behaviour was to allow it to be nil. initialize_http_header in module HTTPHeader (net/http.rb) iterates over all headers. When "Cookie" is set and is nil, this method freaks out when trying to call value.strip. If the "Cookie" header has a value of nil, it should not be included in the headers hash.
|
released v1.1.1. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no cookies, the "Cookies" key shouldn't exist. The
existing behaviour was to allow it to be nil.
initialize_http_header in module HTTPHeader (net/http.rb) iterates over
all headers. When "Cookie" is set and is nil, this method freaks out
when trying to call value.strip. If the "Cookie" header has a value of
nil, it should not be included in the headers hash.