Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog_widget: Add horizontal padding to the modal content. #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbansal1999
Copy link
Owner

@sbansal1999 sbansal1999 commented Aug 13, 2023

Previously, the modal content bottom border sometimes gets hidden due to subpixel rounding.

This happens only at some Zoom levels and on Google Chrome.

Screenshots and screen captures:
On 75% Zoom - Chrome 110
Before After
image image

CZO Discussion: Link

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@sbansal1999 sbansal1999 force-pushed the dialog-widget-fix branch 2 times, most recently from d67e09a to 9270124 Compare August 15, 2023 18:25
Previously, the modal content bottom border sometimes got hidden
due to subpixel rounding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant