Avoid adding hooks for globalThis in MODULARIZE mode

Fixes: emscripten-core#22588
sbc100 · Sep 26, 2024 · 9e3bca8 · 9e3bca8
1 parent fafea90
commit 9e3bca8
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/runtime_debug.js b/src/runtime_debug.js
@@ -56,6 +56,14 @@ function isExportedByForceFilesystem(name) {
  * their build, or no symbols that no longer exist.
  */
 function hookGlobalSymbolAccess(sym, func) {
+#if MODULARIZE && !EXPORT_ES6
+  // In MODULARIZE mode the generated code runs inside a function scope and not
+  // the global scope, and JavaScript does not provide access to function scopes
+  // so we cannot dynamically modify the scrope using `defineProperty` in this
+  // case.
+  //
+  // In this mode we simply ignore requests for `hookGlobalSymbolAccess`.
+#else
   if (typeof globalThis != 'undefined' && !Object.getOwnPropertyDescriptor(globalThis, sym)) {
     Object.defineProperty(globalThis, sym, {
       configurable: true,
@@ -65,6 +73,7 @@ function hookGlobalSymbolAccess(sym, func) {
       }
     });
   }
+#endif
 }
 
 function missingGlobal(sym, msg) {