Add reconnecting to remote dbus #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tkurki
commented
Feb 23, 2018
•
tkurki
commented
- retry on initial connection
- retry on failed connection (Venus turned off for example)
To prepare for retry implementation make dbus connection return a Promise, which allows handling of async success when receiving connect event and async failure when receiving error.
Easier testing without server from command line.
Retry forever with exponential backoff up to 30 seconds.
tkurki
changed the title
Is is possible that the plugin was stopped while the connection was being established, so make sure we are still in started state before acting on the started connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.