forked from awslabs/aws-deployment-framework
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix allow-empty-targets to match style
**Why?** Since the `allow-empty-targets` configuration has not been part of an ADF release yet. We should use this opportunity to make sure that the configuration values it uses match the style of the other variables. **What?** Changed it to match `enabled` and `disabled` as used elsewhere.
- Loading branch information
Showing
8 changed files
with
45 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -158,7 +158,7 @@ def test_prepare_deployment_account_defaults(param_store_cls, cls, sts): | |
'scm/default_scm_codecommit_account_id', | ||
deployment_account_id, | ||
), | ||
call('deployment_maps/allow_empty_target', 'False'), | ||
call('deployment_maps/allow_empty_target', 'disabled'), | ||
call('org/stage', 'none'), | ||
call('notification_type', 'email'), | ||
call('notification_endpoint', '[email protected]'), | ||
|
@@ -203,7 +203,7 @@ def test_prepare_deployment_account_specific_config(param_store_cls, cls, sts): | |
'stage': 'test-stage', | ||
} | ||
cls.config['deployment-maps'] = { | ||
'allow-empty-target': 'False', | ||
'allow-empty-target': 'disabled', | ||
} | ||
prepare_deployment_account( | ||
sts=sts, | ||
|
@@ -260,7 +260,7 @@ def test_prepare_deployment_account_specific_config(param_store_cls, cls, sts): | |
'scm/default_scm_codecommit_account_id', | ||
deployment_account_id, | ||
), | ||
call('deployment_maps/allow_empty_target', 'False'), | ||
call('deployment_maps/allow_empty_target', 'disabled'), | ||
call('org/stage', 'test-stage'), | ||
call('notification_type', 'slack'), | ||
call( | ||
|