Fix setRegionToRecord and showCancel button on record fail popup

sbondCo · Dec 27, 2023 · 9996a38 · 9996a38
1 parent c4e4280
commit 9996a38
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/libs/recorder/index.ts b/src/libs/recorder/index.ts
@@ -25,7 +25,8 @@ ipcRenderer.on("startStopRecordingSavedRegion-pressed", async () => {
     Notifications.popup({
       id: "CANT-RECORD-SR",
       title: "Can't Record Saved Region!",
-      message: "A width and or height has not been provided in settings!"
+      message: "A width and or height has not been provided in settings!",
+      showCancel: true
     }).catch((err) => logger.error("Recorder", "Failed to show CANT-RECORD-SR popup", err));
     return;
   }

diff --git a/src/settings/settingsSlice.ts b/src/settings/settingsSlice.ts
@@ -86,10 +86,10 @@ const settingsSlice = createSlice({
       state.recording.hardwareEncoding = action.payload;
     },
     setRegionToRecord(state, action: PayloadAction<{ x?: number; y?: number; width?: number; height?: number }>) {
-      if (action.payload.x) state.recording.regionToRecord.x = action.payload.x;
-      if (action.payload.y) state.recording.regionToRecord.y = action.payload.y;
-      if (action.payload.width) state.recording.regionToRecord.width = action.payload.width;
-      if (action.payload.height) state.recording.regionToRecord.height = action.payload.height;
+      if (typeof action.payload.x === "number") state.recording.regionToRecord.x = action.payload.x;
+      if (typeof action.payload.y === "number") state.recording.regionToRecord.y = action.payload.y;
+      if (typeof action.payload.width === "number") state.recording.regionToRecord.width = action.payload.width;
+      if (typeof action.payload.height === "number") state.recording.regionToRecord.height = action.payload.height;
     },
 
     //