Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix poster focus/accessibility issues and middle clicking #647

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Fix poster focus/accessibility issues and middle clicking #647

merged 7 commits into from
Oct 3, 2024
+214 −121

Conversation

IRHM
Copy link
Member

@IRHM IRHM commented Oct 3, 2024

Changes made

  • Poster can now be middle clicked anywhere in middle (except rating/status buttons) to open in new tab (used to be only title that had the link).
  • Fixed posters being refocused after tab regains focus (eg, middle click poster, go to new tab, come back, poster is reactivated for no reason).
  • Fixed can't unfocus a poster after giving it a rating/status through poster quick actions (mobile).
  • Improved keyboard accessibility for tabbing through posters:
    • One less irrelevant element per poster to tab through
    • Tabbing to anywhere in a poster will now always center the whole poster into view
    • Hide extraDetails when poster activated by tabbing to it.

Fixes #620

@IRHM
Posters: Fix focus style (only apply if focused via keyboard)
7cfbc6c
@IRHM
Poster: Set tabindex to -1 for inner container to avoid extra element…
6d5aa0f 
… to highlight when tabbing through

The inner container is not helpful for highlighting when tabbing through posters. The title of poster can still be used to enter the content via keyboard, the inner container did the same thing so was redundant and only added an extra click for any navigating via keyboard.
@IRHM
Posters: Fix keyboard focus not hiding ExtraDetails
2b78581 
Focus events now do same thing and mouse enter/leave (focusin/out), so we have the same behaviour.
@IRHM
Posters: Fix mobile tab and hold link
31ce745
@IRHM
Posters: Fix mouseleave from rating/status menus causing extraDetails…
5a70b8a 
… to show

hopefully they were left here by accident
@IRHM
Poster: Fix issues i made 11 days ago
48814c2
@IRHM
Poster: fix being re-focused after window regain focus
ed9a9aa
@IRHM IRHM added bug Hmm, this isn't working correctly enhancement New feature or request labels Oct 3, 2024
@IRHM IRHM changed the title Fix poster focus issue and middle clicking Fix poster focus/accessibility issues and middle clicking Oct 3, 2024
@IRHM IRHM merged commit 8d34513 into dev Oct 3, 2024
1 check passed
@IRHM IRHM deleted the fix-poster-focus branch October 3, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Hmm, this isn't working correctly enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: middle click not working properly
1 participant
@IRHM