Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Deprecated GraphMatrices functions #564

Closed
jpfairbanks opened this issue Mar 23, 2017 · 2 comments
Closed

Deprecated GraphMatrices functions #564

jpfairbanks opened this issue Mar 23, 2017 · 2 comments

Comments

@jpfairbanks
Copy link
Contributor

These functions are deprecated

A_mul_B!(Y, A::Noop, B) = copy!(Y, B),
convert(::Type{Adjacency}, lapl::Laplacian) = lapl.A, and
convert(::Type{SparseMatrix}, adjmat::CombinatorialAdjacency) = adjmat.A

@deprecate A_mul_B!(Y, A::Noop, B) None
@deprecate convert(::Type{Adjacency}, lapl::Laplacian) None
@deprecate convert(::Type{SparseMatrix}, adjmat::CombinatorialAdjacency) sparse(adjmat)
@sbromberger
Copy link
Owner

sbromberger commented Mar 23, 2017 •
edited
Loading

Are you creating a PR to deprecate them?

I can just make the edits to the simplegraphs branch directly if you'd like....

sbromberger added a commit that referenced this issue Mar 23, 2017
@sbromberger
fixes #564
ab176b8
@sbromberger
Copy link
Owner

I'm on it.

sbromberger added a commit that referenced this issue Mar 29, 2017
@sbromberger
WIP: LightGraphs Abstraction (#541)
c93b73a 
* benchmarks

* add edgetype benchmark

katz centrality is broken.

* simplegraphs abstraction

* Edge is no longer a Pair

* pkgbenchmarks

* f

* remove data files from benchmarks

* simplegraphs, take 2

* more changes

* reshuffle

* fix tests

* more tests

* abstractions

* more tests

* tests and fixes

* trait fixes and tests - unrolling

* persistence and floyd-warshall

* make(di)graphs, through spanningtrees

* moved cliques, testing through connectivity.jl

* @jpfairbanks first round of review

* another fix

* all tests

* new simpletraits

* first cut at 0.6 compat

* squash

* update randgraphs.jl to use Channels over Tasks

Fixes deprecation warnings introduced in:

  JuliaLang/julia#19841

Changes an API interface:

  -function Graph(nvg::Int, neg::Int, edgestream::Task)
  +function Graph(nvg::Int, neg::Int, edgestream::Channel)

Iteration over Tasks is deprecated so now we iterate over the Channel.

* got rid of tasks in randgraphs

* graph -> g

* Add tutorials to section on docs (#547)

* Update README.md

* Update README.md

Made tutorials separate line and consistent with the other lines.

* type -> mutable struct

* more type -> mutable struct, plus OF detection for add_vertex!

* foo{T}(x::T) -> foo(x::T) where T

* test negative cycles

* test coverage

* manual cherry-pick of #551

* simplegraph/ -> simplegraphs, optimization for is_connected, some type simplifications

* re-add b-f tests

* Inferred (#554)

* core

* @inferred wherever possible

* empty -> zero

* test grid periodic=true

* oops

* redo graphmatrices tests

* linalg test fix

* loosen type restrictions in randgraphs functions

* readall -> readstring, and comment rationalization in randgraphs

* Fixes #555: graphmatrices convert incorrect on CA (#560)

CombinatorialAdjacency(CombinatorialAdjacency(g)) was returning the backing storage.
Fix includes tests.

* fixes #564

* one more test

* removed nv() and vertices() (#565)

* simpleedge tests

* test coverage

* short circuit B-F negative cycles, plus tests

* more test coverage

* more test coverage

* Docs (#567)

* docs, plus some various fixes (see blocking_flow).

* nodes -> vertices, node -> vertex, and more doc consistency

* doc fixes

* 1.0 -> 0.8

* docfix and benchmarks

* doc fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbromberger @jpfairbanks