Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API exposes private type #209

Open
bbjubjub2494 opened this issue Dec 15, 2018 · 0 comments
Open

API exposes private type #209

bbjubjub2494 opened this issue Dec 15, 2018 · 0 comments
Labels

Comments

@bbjubjub2494
Copy link

Description

A bunch of methods in Using have OpenFile[T] as their return type, which is private.

How to reproduce

View the sbt.io.Using class in scaladoc and look at e.g. fileInputStream.

Expected behaviour

The type should be more descriptive. It took me a while to figure out that it was a subtype of Using[File, T], so I reckon changing the exposed type could improve UX. I don't know if there's a particular reason.

This would break binary compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants