Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid exposing private type in API #210

Merged
merged 1 commit into from
Aug 18, 2019
Merged

avoid exposing private type in API #210

merged 1 commit into from
Aug 18, 2019

Conversation

bbjubjub2494
Copy link

Fix #209. breaks binary compatibility.

@eed3si9n eed3si9n added the ready label Dec 15, 2018
@bbjubjub2494
Copy link
Author

Maybe a [use case] simplified signature could be used between now and the next binary-incompatible release?

@typesafe-tools
Copy link

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt develop sbt/sbt@4c55383
zinc develop sbt/zinc@9bef954
io pull/210/head 6a1a47c
librarymanagement develop sbt/librarymanagement@9107125
util develop sbt/util@2e0d2d9

❌ The result is: FAILED
(restart)

@eed3si9n
Copy link
Member

In https://jenkins.scala-sbt.org:8592/job/sbt-validator/1259/consoleFull, Dbuild is reporting that this will cause

[sbt212:error] java.lang.StackOverflowError
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:814)
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:814)
...

during

[sbt212] [error] Error during tests:
[sbt212] [error] 	sbt.internal.util.SettingsTest

I am kind of confused why this is the case.

@typesafe-tools
Copy link

A validation involving this pull request is in progress...

@typesafe-tools
Copy link

The validator has checked the following projects, tested using sbt-allsources.sh.

Project Reference Commit
sbt develop sbt/sbt@4c55383
zinc develop sbt/zinc@9bef954
io pull/210/head 6a1a47c
librarymanagement develop sbt/librarymanagement@9107125
util develop sbt/util@2e0d2d9

❌ The result is: FAILED
(restart)

@typesafe-tools
Copy link

A validation involving this pull request is in progress...

@typesafe-tools
Copy link

The validator has checked the following projects, tested using sbt-allsources.sh.

Project Reference Commit
sbt develop sbt/sbt@4c55383
zinc develop sbt/zinc@9bef954
io pull/210/head~ ca872a2
librarymanagement develop sbt/librarymanagement@9107125
util develop sbt/util@2e0d2d9

❌ The result is: FAILED
(restart)

OpenFile is a private implementation of Using, so it's clearer for library users
to just see Using instead.
@bbjubjub2494
Copy link
Author

Rebased onto develop, I seemed to have missed some recent commits for unknown reasons.

@typesafe-tools
Copy link

A validation involving this pull request is in progress...

@typesafe-tools
Copy link

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt develop sbt/sbt@4c55383
zinc develop sbt/zinc@9bef954
io pull/210/merge
librarymanagement develop sbt/librarymanagement@9107125
util develop sbt/util@2e0d2d9

❌ The result is: FAILED
(restart)

@typesafe-tools
Copy link

A validation involving this pull request is in progress...

@typesafe-tools
Copy link

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt develop sbt/sbt@4c55383
zinc develop sbt/zinc@9bef954
io pull/210/head c4f6dc7
librarymanagement develop sbt/librarymanagement@9107125
util develop sbt/util@2e0d2d9

❌ The result is: FAILED
(restart)

@bbjubjub2494
Copy link
Author

Well it seems like I learned the hard way that @usecase is a terrible idea and already deprecated. (See scala/scala-dev#584) It chokes on vals and on defaulted parameters, so I can't make it work on all the definitions I would like to. Let's not do that.

As it stands, this PR targets 2.0.

@eed3si9n eed3si9n changed the base branch from develop to topic/2.x_using_cleanup August 18, 2019 03:18
@eed3si9n
Copy link
Member

I'll create a branch to track this for future merge.

@eed3si9n eed3si9n merged commit 0c30fc0 into sbt:topic/2.x_using_cleanup Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants