-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid exposing private type in API #210
avoid exposing private type in API #210
Conversation
Maybe a [use case] simplified signature could be used between now and the next binary-incompatible release? |
The validator has checked the following projects, tested using dbuild, projects built on top of each other.
❌ The result is: FAILED |
In https://jenkins.scala-sbt.org:8592/job/sbt-validator/1259/consoleFull, Dbuild is reporting that this will cause
during
I am kind of confused why this is the case. |
A validation involving this pull request is in progress... |
The validator has checked the following projects, tested using sbt-allsources.sh.
❌ The result is: FAILED |
A validation involving this pull request is in progress... |
The validator has checked the following projects, tested using sbt-allsources.sh.
❌ The result is: FAILED |
OpenFile is a private implementation of Using, so it's clearer for library users to just see Using instead.
Rebased onto develop, I seemed to have missed some recent commits for unknown reasons. |
A validation involving this pull request is in progress... |
The validator has checked the following projects, tested using dbuild, projects built on top of each other.
❌ The result is: FAILED |
A validation involving this pull request is in progress... |
The validator has checked the following projects, tested using dbuild, projects built on top of each other.
❌ The result is: FAILED |
Well it seems like I learned the hard way that As it stands, this PR targets 2.0. |
I'll create a branch to track this for future merge. |
Fix #209. breaks binary compatibility.