add note to readme #218
Merged
add note to readme #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
reviewed
Dec 11, 2021
readme.md
Outdated
| sonatypeCredentialHost := "s01.oss.sonatype.org" | ||
| sonatypeRepository := "https://s01.oss.sonatype.org/service/local" | ||
| ``` | ||
| to your root project |
There was a problem hiding this comment.
Should this be scoped to the root project or ThisBuild?
There was a problem hiding this comment.
I... honestly don't know what it 'should' be. Best practice with ThisBuild in sbt has always eluded me. I think it's probably sanest to include it with the other publishing settings, so I'll try to suggest that in the copy...
|
I've moved this a bit higher up in the readme, and tried to imply that the settings should be included with the rest of the publishing settings. Thanks for the prompt review! Hope this looks better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information is available in the issues, but it took me a while to figure out what was going wrong, so thought it would be good to add to the (otherwise excellent) readme