Add new line at end of githubWorkflowGenerate files #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #69. As can be seen, the solution is a very simple one where we just use
BufferedWriter.newLine
after we write the contents. The advantage here is none of the tests needed to be adjusted since the tests compareString
outputs fromcompileWorkflow
which happens before any file generated and hence the disadvantage is that this codepath is not tested since there is no existing test that makes use ofgithubWorkflowGenerate
.@djspiewak Do you want me to write a test for this, and if so how would you like to do it? Simplest thing I can think of is to move some code out of
githubWorkflowGenerate
into a function and to write a simple test that some generated files end with a new line?