Properly prune dumpLicenseInfo reports #57
Conversation
mdedetrich
force-pushed
the
make-prune-work-multi-config-setup
branch
4 times, most recently
from
91b0d61
to
fb08d51
Compare
| @@ -106,25 +110,26 @@ object SbtLicenseReport extends AutoPlugin { | |||
| ) | |||
| Seq(config) | |||
| }, | |||
| dumpLicensePruneDuplicates := true, | |||
There was a problem hiding this comment.
Default setting should probably go into globalSettings to have the most flexibility - https://www.scala-sbt.org/1.x/docs/Plugins-Best-Practices.html#Provide+default+values+in
There was a problem hiding this comment.
I can't imagine a situation where people would want to set this setting to false though. Does this need to be a setting?
There was a problem hiding this comment.
Default setting should probably go into globalSettings to have the most flexibility
Done
I can't imagine a situation where people would want to set this setting to false though. Does this need to be a setting?
Only thing I can come up with is debugging, but its not a great answer. I can also remove it if you want.
There was a problem hiding this comment.
Done, also renamed commit to be more precise in its wording.
mdedetrich
force-pushed
the
make-prune-work-multi-config-setup
branch
4 times, most recently
from
f8b93e9
to
fe602a5
Compare
mdedetrich
force-pushed
the
make-prune-work-multi-config-setup
branch
from
fe602a5
to
2cc5c42
Compare
mdedetrich
force-pushed
the
make-prune-work-multi-config-setup
branch
from
2cc5c42
to
aa182e9
Compare
mdedetrich
changed the title
In #55 I used
distinctto filter out duplicate entries however it turns out there is a corner case which I missed regarding differing configs, i.e. dependency A in one sbt project its inTestconfig and in another project its in default config. This could happen because theDepLicensedata structure that is derived fromupdateLicensecontains the configs for that given dependency and so if they differ they won't get filtered out bydistinct.This PR solves the problem in a different way, which is to add a
dumpLicensePruneDuplicatesthat works by pruning out the duplicates in the data structure that is used just before actually writing out the contexts. That way we have the behaviour that a user expects, i.e. not having the exact same rows generated in the report.A test has been added which fails when you set
dumpLicensePruneDuplicatestofalse.@eed3si9n I have a couple more fixes incoming when I tried to use this within Pekko so I will let you know when to make a new release.