Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup .gitignore #67

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Cleanup .gitignore #67

merged 1 commit into from
Apr 19, 2023

Conversation

mdedetrich
Copy link
Contributor

The current .gitignore file has a lot of IDE/Editor/OS settings which shouldn't sit inside .gitignore (thats what a global .gitignore is for).

This .gitignore was generated by Intellij which has a more precise template.

@eed3si9n
Copy link
Member

I personally have a global exclude file for git but many other people do not seem to, and I can't count the number of times when I tried to reject pull request of people adding IDE-specific things into the .gitignore. Now I've sorted of given up, and let people add whatever they want into the .gitignore because I don't think it hurts anyone to have more ignores.

@mdedetrich
Copy link
Contributor Author

Okay feel free to close the PR then, the current version is not doing any damage. There does however seem to be a lot of stuff there which seems quite odd and even ancient?

@@ -1,24 +1,20 @@
*.iml
*.lock
*.komodoproject
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of what I mean by odd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea. I have no idea what that is.

Copy link
Contributor Author

@mdedetrich mdedetrich Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I don't know how strongly you feel about this. The main reason why I did this change in the first place is as you can tell there is a lot of weird stuff in this .gitignore and it took me a few minutes to just create a nice clean one.

I can go through the .gitignore to just remove the really weird stuff but tbh almost every entry that isnt editor/IDE related seems wrong one way or another. I get your point about people not doing the proper thing and using a global .gitignore but in my view I don't think should block the PR. Assuming we merge this PR, if someone in the future submits a PR and then complains that their files are being committed and add an entry to the .gitignore you can always accept it.

Alternately I can just add the various IDE/OS specific entries we are talking about but to me this is unnecessary since no one is complaining about it now. In other words, while past contributors may have complained that doesn't mean future ones will and if they do they can always add onto .gitignore.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll merge as is.

@eed3si9n eed3si9n merged commit 22d56e1 into sbt:main Apr 19, 2023
@mdedetrich mdedetrich deleted the cleanup-gitignore-file branch April 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants