Change autoImport def's to val's #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
May 12, 2023
| @@ -12,18 +12,18 @@ object SbtLicenseReport extends AutoPlugin { | |||
| object autoImportImpl { | |||
| // Types and objects to auto-expose | |||
| type LicenseCategory = sbtlicensereport.license.LicenseCategory | |||
| def LicenseCategory = sbtlicensereport.license.LicenseCategory | |||
| val LicenseCategory = sbtlicensereport.license.LicenseCategory | |||
There was a problem hiding this comment.
I guess in theory def could potentially prevent eager evaluation and memory leaks, but likely a moot here since most of these are used in the setting code below?
There was a problem hiding this comment.
Yes correct, its being immediately used
eed3si9n
approved these changes
May 12, 2023
eed3si9n
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I am missing something I am pretty sure these can be
valinstead ofdefdefijitions