Reduce pressure on GC by using a Traversable instead of a Seq #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainreuillon
added a commit
to openmole/openmole
that referenced
this pull request
Oct 24, 2023
mdedetrich
reviewed
Oct 24, 2023
| def content = | ||
| sbt.Path.contentOf(tmpArtifactDirectoryPath).filterNot { case (_, p) => p == "META-INF/MANIFEST.MF" } | ||
| def content = { | ||
| import _root_.java.nio.file.* |
There was a problem hiding this comment.
Can we use ._ instead of .* here so its consistent with the rest of the project?
Otherwise lgtm
|
@mdedetrich I just changed * for _ in the import statements |
mdedetrich
approved these changes
Oct 24, 2023
|
@romainreuillon I just released sbt-osgi |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing file using contentOf primitive return a Sequence. In large projects building many concurrent bundles in parallels this put a lot of pressure on the GC. This patch uses a Traversable instead of a Seq to reduce this pressure.