Adding local search with @cmfcmf-plugin

[FilipHarald]

A first solution to #6

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
scaffold-eth-2-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 12, 2024 4:03pm

[FilipHarald]

Example:

simplescreenrecorder-2024-08-13_16.03.37.mp4

[FilipHarald]

Used wrong branch. Will leave this PR in draft until #76 is done.

[Pabl0cks]

Thanks Filip for tackling this! 🙌 It's looking good to me! It's a basic search but I think it gets the job done.

In terms of UI/UX has a couple of things that could be better, but they are nitpicks and probably it's not worth to invest the time in try to tweak the css from the plugin.

I've only pushed a nitpick in README (014a1aa) to try to make it more readable and a config setting (decbb50) to show category context in the search results modal:

Before	After

[technophile-04]

Hey thanks @FilipHarald!! for tacking it! Looks good to me!

Did you try using easyops-cn/docusaurus-search-local? It seems a forked version of cmcf/search-local but with more stars and also some nitpicky good feature which were missing in cmcf/search-local example cmd + k to focus on search bar and also the search bar looks complete as compared to cmcf one also it seems to give better customisation options incase we need.

could you also create an PR with easyops-cn/docusaurus-search-local? I think it should be easy? since it seems like direct replacement to cmcf loca search?

[FilipHarald]

@technophile-04 , yup, I made a low-effort try and didn't get it to work. I wrote that here: #6 (comment) .

But I didn't look into it more then since I didn't know if it was going to be used. But I can do that now during the coming days 👍 . I will take @Pabl0cks improvements into account as well.

[technophile-04]

Hey @FilipHarald any updates on this? Also happy to merge this as it is! I think it gets the job done for now and we can always update later.

A small nitpick(if it gets hard we could merge this as it is) but:

Can me make this Search bar a bit bigger?

Seem like it is too much cramped in

And another ctrl + k or some keyboard shortcut to open it up.

I would say don't waste lot of time on it, we could always iterate later but would be great if we get them working!

[FilipHarald]

Hello, sorry, no other things got in the way. I'll have a short look now on ctrl+k and sizing.

[FilipHarald]

Shortcut-key seems to be an issue currently: cmfcmf/docusaurus-search-local#50

[FilipHarald]

@technophile-04 to be honest I kind on like having the search bar small, since you are not typing in it there anyway. But I've added width to it now. 👍

[technophile-04]

@technophile-04 to be honest I kind on like having the search bar small, since you are not typing in it there anyway. But I've added width to it now. 👍

Yup agree, it breaks on phone too :(

Let's revert that commit, we could update the styles later 🙌

[technophile-04]

Thanks @FilipHarald!! Lets keep iterating on this!!