Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob.stream() return type is wrong #515

Closed
armanbilge opened this issue Aug 29, 2021 · 0 comments
Closed

Blob.stream() return type is wrong #515

armanbilge opened this issue Aug 29, 2021 · 0 comments
Assignees
@armanbilge
Labels
bug
Milestone
v2.0.0

Comments

@armanbilge
Copy link
Member

https://github.com/scala-js/scala-js-dom/blob/series/1.x/src/main/scala/org/scalajs/dom/raw/lib.scala#L7951

Should be a ReadableStream[Uint8Array]. Came up in http4s/http4s#5120.
@armanbilge armanbilge added the bug label Aug 29, 2021
@armanbilge armanbilge self-assigned this Aug 29, 2021
@armanbilge armanbilge added this to the v2.0.0 milestone Sep 4, 2021
armanbilge added a commit that referenced this issue Sep 4, 2021
@armanbilge
Fix #515 Request extends Body
686651b
japgolly added a commit that referenced this issue Sep 4, 2021
@japgolly
Merge pull request #551 from scala-js/issue/515
30d0e6b 
Fix #515 Blob.stream() emits Uint8Array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armanbilge armanbilge

Labels
bug
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@armanbilge