Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make opaque string types subtype String #603

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Make opaque string types subtype String #603

merged 1 commit into from
Oct 17, 2021

Conversation

japgolly
Copy link
Contributor

Closes #594

armanbilge
armanbilge approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meep meep.

src/main/scala/org/scalajs/dom/RTCConfiguration.scala Show resolved Hide resolved
@armanbilge armanbilge merged commit cf24b55 into master Oct 17, 2021
@armanbilge armanbilge deleted the topic/opaque-subtyping branch October 17, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should opaque types subtype String?
2 participants
@japgolly @armanbilge